belliottsmith commented on code in PR #226:
URL: https://github.com/apache/cassandra-accord/pull/226#discussion_r2222735647
##########
accord-core/src/main/java/accord/impl/progresslog/DefaultProgressLog.java:
##########
@@ -351,15 +353,31 @@ public void clearBefore(SafeCommandStore safeStore, TxnId
clearWaitingBefore, Tx
}
}
+ @Override
+ public void start()
+ {
+ commandStore.maybeExecuteImmediately(() -> {
+ stopped = false;
+ accept(null);
+ });
+ }
+
+ @Override
+ public void stop()
+ {
+ stopped = true;
Review Comment:
I did play around with this a few ways, but to avoid making modifications to
the AsyncExecutor API (that would be sort of inconsistent with ExecutorPls), I
simply made it volatile, so it is safe to change whenever.
We do need to rationalise our async/executor APIs eventually, it continues
to cause some friction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
