frankgh commented on code in PR #237:
URL: https://github.com/apache/cassandra-sidecar/pull/237#discussion_r2226572612
##########
server/src/main/java/org/apache/cassandra/sidecar/modules/SidecarSchemaModule.java:
##########
@@ -50,13 +55,16 @@ public SidecarSchema sidecarSchema(Vertx vertx,
SidecarInternalKeyspace sidecarInternalKeyspace = new
SidecarInternalKeyspace(configuration);
// register table schema when enabled
resolver.resolve().values().forEach(tableSchema -> {
+ LOGGER.info("Registering table schema: {}", tableSchema);
try
{
sidecarInternalKeyspace.registerTableSchema(tableSchema);
}
catch (Throwable cause)
{
- throw new RuntimeException("Failed to register table schema: "
+ tableSchema, cause);
+ String message = "Failed to register table schema: " +
tableSchema;
+ LOGGER.error(message);
+ throw new RuntimeException(message, cause);
Review Comment:
yeah good point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
