yifan-c commented on code in PR #238:
URL: https://github.com/apache/cassandra-sidecar/pull/238#discussion_r2229291129
##########
adapters/adapters-base/src/main/java/org/apache/cassandra/sidecar/adapters/base/CassandraMetricsOperations.java:
##########
@@ -61,14 +61,13 @@ public class CassandraMetricsOperations implements
MetricsOperations
private final ConnectedClientStatsDatabaseAccessor dbAccessor;
protected final JmxClient jmxClient;
-
/**
* Creates a new instance with the provided {@link CQLSessionProvider}
*/
- public CassandraMetricsOperations(JmxClient jmxClient, CQLSessionProvider
session)
+ public CassandraMetricsOperations(JmxClient jmxClient, TableSchemaFetcher
tableSchemaFetcher, ICassandraAdapter cassandraAdapter)
Review Comment:
`CassandraMetricsOperations` are targeting local node. We almost do not want
to connect to other nodes from within the operations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
