adelapena commented on code in PR #4249:
URL: https://github.com/apache/cassandra/pull/4249#discussion_r2231126240
##########
src/java/org/apache/cassandra/cql3/restrictions/MergedRestriction.java:
##########
@@ -292,11 +294,23 @@ public boolean needsFiltering(Index.Group indexGroup)
}
@Override
- public Index findSupportingIndex(Iterable<Index> indexes)
+ public Index findSupportingIndex(IndexRegistry indexRegistry, IndexHints
indexHints)
Review Comment:
I think we can deduplicate the tow versions of `findSupportingIndex` and
keep the changes done by CASSANDRA-19341 this way:
https://github.com/adelapena/cassandra/commit/52fbc4bd540178c2eab80c33c3ff5727c2b3198c
##########
src/java/org/apache/cassandra/cql3/restrictions/MergedRestriction.java:
##########
@@ -292,11 +294,23 @@ public boolean needsFiltering(Index.Group indexGroup)
}
@Override
- public Index findSupportingIndex(Iterable<Index> indexes)
+ public Index findSupportingIndex(IndexRegistry indexRegistry, IndexHints
indexHints)
Review Comment:
I think we can deduplicate the two versions of `findSupportingIndex` and
keep the changes done by CASSANDRA-19341 this way:
https://github.com/adelapena/cassandra/commit/52fbc4bd540178c2eab80c33c3ff5727c2b3198c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
