Mmuzaf commented on code in PR #2497: URL: https://github.com/apache/cassandra/pull/2497#discussion_r2232059359
########## src/java/org/apache/cassandra/tools/nodetool/Compact.java: ########## @@ -17,41 +17,46 @@ */ package org.apache.cassandra.tools.nodetool; -import static org.apache.commons.lang3.StringUtils.EMPTY; - -import io.airlift.airline.Arguments; -import io.airlift.airline.Command; -import io.airlift.airline.Option; - import java.util.ArrayList; import java.util.List; import org.apache.cassandra.tools.NodeProbe; -import org.apache.cassandra.tools.NodeTool.NodeToolCmd; +import org.apache.cassandra.tools.nodetool.layout.CassandraUsage; +import picocli.CommandLine.Command; +import picocli.CommandLine.Option; +import picocli.CommandLine.Parameters; + +import static org.apache.cassandra.tools.nodetool.CommandUtils.parseOptionalKeyspace; +import static org.apache.cassandra.tools.nodetool.CommandUtils.parseOptionalTables; +import static org.apache.commons.lang3.StringUtils.EMPTY; +// TODO CASSANDRA-xxxxx Types of input aguments shouldn't be mixed in the same command. The keyspace, table and SSTable file arguments should have their own commands. Review Comment: I'll create an issue right before the commit, yes. There is no need to create them in advance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
