Mmuzaf commented on code in PR #2497: URL: https://github.com/apache/cassandra/pull/2497#discussion_r2232093792
########## test/unit/org/apache/cassandra/tools/nodetool/mock/AbstractNodetoolMock.java: ########## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.tools.nodetool.mock; + +import java.util.HashMap; +import java.util.Map; +import javax.management.NotificationBroadcasterSupport; +import javax.management.NotificationEmitter; +import javax.management.StandardEmitterMBean; +import javax.management.StandardMBean; + +import org.apache.cassandra.service.accord.AccordOperationsMBean; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; + +import org.apache.cassandra.batchlog.BatchlogManagerMBean; +import org.apache.cassandra.cql3.CQLTester; +import org.apache.cassandra.db.ColumnFamilyStoreMBean; +import org.apache.cassandra.db.compaction.CompactionManagerMBean; +import org.apache.cassandra.gms.FailureDetectorMBean; +import org.apache.cassandra.gms.GossiperMBean; +import org.apache.cassandra.hints.HintsServiceMBean; +import org.apache.cassandra.locator.EndpointSnitchInfoMBean; +import org.apache.cassandra.locator.LocationInfoMBean; +import org.apache.cassandra.net.MessagingServiceMBean; +import org.apache.cassandra.service.CacheServiceMBean; +import org.apache.cassandra.service.StorageProxyMBean; +import org.apache.cassandra.service.StorageServiceMBean; +import org.apache.cassandra.service.snapshot.SnapshotManagerMBean; +import org.apache.cassandra.tools.NodeTool; +import org.apache.cassandra.tools.ToolRunner; +import org.apache.cassandra.utils.MBeanWrapper; +import org.mockito.Mockito; + +import static org.apache.cassandra.db.ColumnFamilyStore.getColumnFamilieMBeanName; + +public abstract class AbstractNodetoolMock extends CQLTester +{ + public static final String[] EMPTY_STRING_ARRAY = {}; + + public static final String ACCORD_OPERATIONS_MBEAN = "org.apache.cassandra.service.accord:type=AccordOperations"; + public static final String BATCHLOG_MANAGER_MBEAN = "org.apache.cassandra.db:type=BatchlogManager"; + public static final String CACHE_SERVICE_MBEAN = "org.apache.cassandra.db:type=Caches"; + public static final String COMPACTION_MANAGER_MBEAN = "org.apache.cassandra.db:type=CompactionManager"; + public static final String ENDPOINT_SNITCH_INFO_MBEAN = "org.apache.cassandra.db:type=EndpointSnitchInfo"; + public static final String FAILURE_DETECTOR_MBEAN = "org.apache.cassandra.net:type=FailureDetector"; + public static final String GOSSIPER_MBEAN = "org.apache.cassandra.net:type=Gossiper"; + public static final String HINTS_SERVICE_MBEAN = "org.apache.cassandra.hints:type=HintsService"; + public static final String LOCATION_INFO_MBEAN = "org.apache.cassandra.db:type=LocationInfo"; + public static final String MESSAGING_SERVICE_MBEAN = "org.apache.cassandra.net:type=MessagingService"; + public static final String SNAPSHOT_MANAGER_MBEAN = "org.apache.cassandra.service.snapshot:type=SnapshotManager"; + public static final String STORAGE_PROXY_MBEAN = "org.apache.cassandra.db:type=StorageProxy"; + public static final String STORAGE_SERVICE_MBEAN = "org.apache.cassandra.db:type=StorageService"; + + private static final Map<String, Class<?>> mbeans = new HashMap<>(); + private static final MBeanWrapper mbeanServer = MBeanWrapper.instance; + + static + { + mbeans.put(ACCORD_OPERATIONS_MBEAN, AccordOperationsMBean.class); + mbeans.put(BATCHLOG_MANAGER_MBEAN, BatchlogManagerMBean.class); + mbeans.put(CACHE_SERVICE_MBEAN, CacheServiceMBean.class); + mbeans.put(COMPACTION_MANAGER_MBEAN, CompactionManagerMBean.class); + mbeans.put(ENDPOINT_SNITCH_INFO_MBEAN, EndpointSnitchInfoMBean.class); Review Comment: Yes, this is probably not good, but such a refactoring is probably unrelated to these changes, so it's better to address it in a follow-up issue. This will ensure that the changes are safe and minimalistic (changing the MBean will alter the command behavior). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
