yifan-c commented on code in PR #240:
URL: https://github.com/apache/cassandra-sidecar/pull/240#discussion_r2233745411


##########
build.gradle:
##########
@@ -323,6 +325,33 @@ tasks.register('copyDocs', Copy) {
     exclude "tmp"
 }
 
+// Exclude some tasks to speed up running ./gradlew run
+if ("run" in gradle.startParameter.taskNames) {
+    project.gradle.startParameter.excludedTaskNames.add("codeCheckTasks")
+    project.gradle.startParameter.excludedTaskNames.add("asciidoctor")
+}
+
+gradle.taskGraph.whenReady { taskGraph ->
+    if ("run" in gradle.startParameter.taskNames) {
+        def exclusionTasks = tasks.findAll {
+            // integration tests
+            it.name == "integrationTest" ||
+                    // distribution plugin tasks
+                    it.name.startsWith('dist') || 
it.name.startsWith('assembleDist') ||
+                    // tar, deb, zip, rpm tasks
+                    it.name.endsWith("Tar") || it.name.endsWith("Deb") || 
it.name.endsWith("Rpm") || it.name.endsWith("Zip") ||
+                    // docs
+                    it.name.contains("asciidoctor") || it.name == "copyDocs" ||
+                    // other tasks
+                    it.name.startsWith("spotbugs") || it.name == "rat"

Review Comment:
   Can you use the continuation indent of 0, instead of 8? To be the same as 
Java. 



##########
build.gradle:
##########
@@ -323,6 +325,33 @@ tasks.register('copyDocs', Copy) {
     exclude "tmp"
 }
 
+// Exclude some tasks to speed up running ./gradlew run
+if ("run" in gradle.startParameter.taskNames) {
+    project.gradle.startParameter.excludedTaskNames.add("codeCheckTasks")
+    project.gradle.startParameter.excludedTaskNames.add("asciidoctor")
+}
+
+gradle.taskGraph.whenReady { taskGraph ->

Review Comment:
   good idea



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to