smiklosovic commented on code in PR #4276:
URL: https://github.com/apache/cassandra/pull/4276#discussion_r2236565722
##########
test/unit/org/apache/cassandra/db/commitlog/CommitLogReaderTest.java:
##########
@@ -165,6 +186,54 @@ public void testReadCountFromMidpoint() throws Throwable
confirmReadOrder(testHandler, samples / 2);
}
+ @Test
+ public void testSyncMarkerChecksumReadFailed_ignoreReplayErrorsDisabled()
throws Throwable
Review Comment:
this test fails when executed alone.
Also please consider the usage
````
Assertions.assertThatThrownBy(() ->
reader.readCommitLogSegment(clrHandler,
corruptedSegmentFile,
CommitLogPosition.NONE,
CommitLogReader.ALL_MUTATIONS,
false))
.isInstanceOf(CommitLogReplayer.CommitLogReplayException.class);
````
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
