dcapwell commented on code in PR #4288:
URL: https://github.com/apache/cassandra/pull/4288#discussion_r2248854905
##########
test/simulator/test/org/apache/cassandra/simulator/test/EpochStressTest.java:
##########
@@ -160,7 +170,18 @@ public void manyEpochsAndAccordConverges() throws
IOException
},
config -> config.nodes(3, 3)
.dcs(1, 1)
- .threadCount(100));
+ .threadCount(100),
+ (rs, config) -> {
+ // When the cluster defaults are used then the test will
nearly 100% of the time fail to make it to 100 epochs without the epochs
failing, so want to cover this in case there is a visbility violation somewhere
+ // if the CMS retry configs are set to 1h then the
failure rate becomes 10%, so more seeds will reach all 100 epochs!
+ if (rs.decide(0.3f)) return; // 30% of the time use the
cluster defaults, so have a high failure rate for TCM transactions
Review Comment:
simulator runs a single seed, so didn't think it was worth it to make `0.3`
dynamic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
