yifan-c commented on code in PR #243:
URL: https://github.com/apache/cassandra-sidecar/pull/243#discussion_r2249144245
##########
test-common/src/testFixtures/java/org/apache/cassandra/distributed/impl/CassandraCluster.java:
##########
@@ -70,9 +77,14 @@ public class CassandraCluster<I extends IInstance>
implements IClusterExtension<
return
className.equals("org.apache.cassandra.utils.concurrent.Ref$OnLeak")
||
className.startsWith("org.apache.cassandra.metrics.RestorableMeter")
||
className.equals("org.apache.logging.slf4j.EventDataConverter")
- || (className.startsWith("org.apache.cassandra.analytics.") &&
className.contains("BBHelper"));
+ || (className.startsWith("org.apache.cassandra.sidecar.") &&
className.contains("BBHelper"));
Review Comment:
interesting...
##########
server/src/test/integration/org/apache/cassandra/sidecar/routes/tokenrange/JoiningMultiDCTest.java:
##########
@@ -209,13 +210,8 @@ private Map<String, Map<Range<BigInteger>, List<String>>>
generateExpectedRangeD
dc2Mapping.put(expectedRanges.get(12), Arrays.asList("127.0.0.4",
"127.0.0.6", "127.0.0.2", "127.0.0.10",
"127.0.0.8"));
- return new HashMap<String, Map<Range<BigInteger>, List<String>>>()
- {
- {
- put("datacenter1", dc1Mapping);
- put("datacenter2", dc2Mapping);
- }
- };
+ return Map.of("datacenter1", dc1Mapping,
+ "datacenter2", dc2Mapping);
}
Review Comment:
👍
##########
integration-tests/src/integrationTest/org/apache/cassandra/sidecar/coordination/ClusterLeaseClaimTaskIntegrationTest.java:
##########
@@ -115,32 +111,35 @@ void setup()
@AfterAll
static void cleanup()
{
- TestResourceReaper.create().with(vertx).close();
+ getBlocking(vertx.close(), 10, TimeUnit.SECONDS, "Close vertx");
Review Comment:
Sad to see moving away from `TestResourceReaper` :|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
