frankgh commented on code in PR #246: URL: https://github.com/apache/cassandra-sidecar/pull/246#discussion_r2255808800
########## server/src/main/java/org/apache/cassandra/sidecar/acl/AuthCache.java: ########## @@ -150,27 +150,29 @@ protected void warmUp(int availableRetries) { if (!config.enabled()) { - LOGGER.info("Cache={} not enabled, skipping pre-warming", name); + logger.info("Cache={} not enabled, skipping pre-warming", name); return; } if (availableRetries < 1) { - LOGGER.warn("Retries exhausted, unexpected error pre-warming cache={}", name); + logger.warn("Retries exhausted, unexpected error pre-warming cache={}", name); return; } try { + long startTimeNanos = System.nanoTime(); cache.putAll(bulkLoadFunction.get()); + logger.info("Cache warm completed successfully in {} nanoseconds", System.nanoTime() - startTimeNanos); Review Comment: let's use the cache name here like in the other log entries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org