netudima commented on code in PR #4038:
URL: https://github.com/apache/cassandra/pull/4038#discussion_r2266190231
##########
src/java/org/apache/cassandra/schema/SchemaConstants.java:
##########
@@ -77,14 +78,32 @@ public final class SchemaConstants
*/
public static final int NAME_LENGTH = 48;
+ /**
+ * Longest acceptable file name. Longer names lead to too long file name
error.
+ */
+ public static final int FILENAME_LENGTH = 255;
+
+ /**
+ * Longest acceptable table name, so it can be used in a directory
+ * name constructed with a suffix of a table id and a separator.
+ */
+ public static final int TABLE_NAME_LENGTH = FILENAME_LENGTH - 32 - 1;
+
// 59adb24e-f3cd-3e02-97f0-5b395827453f
public static final UUID emptyVersion;
public static final List<String> LEGACY_AUTH_TABLES =
Arrays.asList("credentials", "users", "permissions");
- public static boolean isValidName(String name)
+ /**
+ * Validates that a name contains only alphanummeric characters or
underscore,
+ * so it can be used in file or directory names.
+ *
+ * @param name the name to check
+ * @return whether the name contains only valid characters
Review Comment:
Yes, I think it would be nice to add (technically an empty string contains
only alphanumeric characters or underscore :-) ) but it is a nit, so up to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
