Maxwell-Guo commented on code in PR #4228:
URL: https://github.com/apache/cassandra/pull/4228#discussion_r2272511156
##########
src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java:
##########
@@ -589,15 +595,31 @@ public static Map<String, String>
validateOptions(Map<String, String> options) t
String levelFanoutSize = options.containsKey(LEVEL_FANOUT_SIZE_OPTION)
? options.get(LEVEL_FANOUT_SIZE_OPTION) :
String.valueOf(DEFAULT_LEVEL_FANOUT_SIZE);
try
{
- int fanoutSize = Integer.parseInt(levelFanoutSize);
+ fanoutSize = Integer.parseInt(levelFanoutSize);
if (fanoutSize < 1)
{
throw new ConfigurationException(String.format("%s must be
larger than 0, but was %s", LEVEL_FANOUT_SIZE_OPTION, fanoutSize));
}
}
catch (NumberFormatException ex)
{
- throw new ConfigurationException(String.format("%s is not a
parsable int (base10) for %s", size, LEVEL_FANOUT_SIZE_OPTION), ex);
+ throw new ConfigurationException(String.format("%s is not a
parsable int (base10) for %s", levelFanoutSize, LEVEL_FANOUT_SIZE_OPTION), ex);
+ }
+
+ // Validate max Bytes for a level
+ try
+ {
+ long maxSSTableSizeInBytes = Math.multiplyExact(ssSize, 1024L *
1024L); // Convert MB to Bytes
+ BigInteger fanoutPower =
BigInteger.valueOf(fanoutSize).pow(MAX_LEVEL_COUNT);
Review Comment:
should we change to :
`BigInteger fanoutPower = BigInteger.valueOf(fanoutSize).pow(MAX_LEVEL_COUNT
- 1);`
cc @dcapwell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
