himanshujindal commented on PR #4304: URL: https://github.com/apache/cassandra/pull/4304#issuecomment-3186371286
@jaydeepkumar1984 I have addressed all the feedback except metrics, which I can do in the next revision if you can point me to a code link. For adding tests, I found this class called ClusterMetadataTestHelper, which I was able to use and extend. This worked really well. Let me know if there is any feedback with how I wrote those tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
