mrktsm commented on code in PR #4316:
URL: https://github.com/apache/cassandra/pull/4316#discussion_r2278193597
##########
src/java/org/apache/cassandra/db/virtual/SettingsTable.java:
##########
@@ -93,8 +95,17 @@ String getValue(Property prop)
if (value == null)
return null;
- if (value.getClass().isArray())
- return Arrays.asList((Object[]) value).toString();
+ if (value.getClass().isArray() || value instanceof Collection || value
instanceof Map)
+ {
+ try {
Review Comment:
`Arrays.asList().toString()` gives `[item1, item2]`, and we need JSON
`["item1", "item2"]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
