michaelsembwever commented on code in PR #4262:
URL: https://github.com/apache/cassandra/pull/4262#discussion_r2281022650
##########
src/java/org/apache/cassandra/utils/memory/BufferPool.java:
##########
@@ -1613,4 +1613,30 @@ int unsafeNumChunks()
+ (pool.chunks.chunk1 != null ? 1 : 0)
+ (pool.chunks.chunk2 != null ? 1 : 0);
}
+
+ /**
+ * @return the inner buffer if it has a BufferPool.Chunk attached
+ * and originalBuffer in other cases
+ */
+ public ByteBuffer unwrapBufferPoolManagedBuffer(ByteBuffer originalBuffer)
+ {
+ int MAX_DEPTH = 32; // a protection against possible loops in
attachments
+ int depth = 0;
+ ByteBuffer buffer = originalBuffer;
+ do
+ {
+ if (buffer == null || !isExactlyDirect(buffer))
+ return originalBuffer;
+ if (Chunk.getParentChunk(buffer) != null)
+ return buffer;
+
+ Object attachment = MemoryUtil.getAttachment(buffer);
+ if (!(attachment instanceof ByteBuffer))
+ return originalBuffer;
Review Comment:
in the two places where we fallback to `return originalBuffer;` is there any
difference if `originalBuffer` or the previous buffer value (not the current
value of `buffer`) was returned ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
