k-rus commented on code in PR #4038: URL: https://github.com/apache/cassandra/pull/4038#discussion_r2282477808
########## .gitignore: ########## @@ -57,6 +57,9 @@ ide/nbproject/private nb-configuration.xml nbactions.xml +#VS code Review Comment: > While in general we opt out of adding outside things to a patch, this one makes sense to me. We just stated clearly in the ticket that there is an additional change and added it in a separate commit for visibility. So in addition to mentioning in the PR I should mention this in the Jira's ticket. Correct me if I misunderstood. Similarly it's not enough that the gitignore is in a commit with changes not directly related to the contribution (https://github.com/apache/cassandra/pull/4038/commits/68b6eb1d3c070d4ed3818f4a9726b97e4315c086), but in a separate commit, so there will be three commits in the PR (VScode in gitignore, linter warning fixes in affected files, and the main contribution for the ticket). Also correct me if I misunderstood. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
