jcshepherd commented on code in PR #4319:
URL: https://github.com/apache/cassandra/pull/4319#discussion_r2283366403
##########
src/java/org/apache/cassandra/auth/NetworkPermissionsCache.java:
##########
@@ -36,7 +36,7 @@ public NetworkPermissionsCache(INetworkAuthorizer authorizer)
DatabaseDescriptor::getRolesCacheActiveUpdate,
authorizer::authorize,
authorizer.bulkLoader(),
- () ->
DatabaseDescriptor.getAuthenticator().requireAuthentication());
+ DatabaseDescriptor::isAuthenticationRequired);
Review Comment:
The intent of this PR, illustrated here, is to remove the assumption that a
node will be configured with a single authenticator. (The dependency shows up
in a couple other ways, which will be addressed with other PRs.) With CEP-50, a
node may be configured with multiple authenticators, and decide at connection
time which authenticator a given connection will use. In a future change,
DatabaseDescriptor will have logic to determine if at least one configured
authenticator requires authentication, but for now it's just passing the call
through to its configured authenticator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
