jaydeepkumar1984 commented on code in PR #4302: URL: https://github.com/apache/cassandra/pull/4302#discussion_r2283806220
########## conf/cassandra.yaml: ########## @@ -2683,10 +2683,14 @@ storage_compatibility_mode: NONE # the given value. Defaults to disabled. # reject_repair_compaction_threshold: 1024 -# At least 20% of disk must be unused to run incremental repair. It is useful to avoid disks filling up during -# incremental repair as anti-compaction during incremental repair may contribute to additional space temporarily. +# At least 20% of disk must be unused to run repair. It is useful to avoid disks filling up during +# repair as anti-compaction during repair may contribute to additional space temporarily. # if you want to disable this feature (the recommendation is not to, but if you want to disable it for whatever reason) # then set the ratio to 0.0 +# repair_disk_headroom_reject_ratio: 0.2; + +# This is the deprecated config which was used to safeguard incremental repairs. Use repair_disk_headroom_reject_ratio Review Comment: I think option#1 is good enough because generally folks run Full Repair along with Incremental Repair, so providing the same behavior on Full Repair is fine. I know it might be a regression for people with Full Repair, but it just improves the Cassandra hot path quality further, so it is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
