dcapwell commented on code in PR #4322: URL: https://github.com/apache/cassandra/pull/4322#discussion_r2286200937
########## src/java/org/apache/cassandra/service/accord/txn/TxnWrite.java: ########## @@ -362,6 +368,9 @@ public void serialize(Fragment fragment, TableMetadatas tables, DataOutputPlus o out.writeUnsignedVInt32(fragment.index); PartitionUpdate.serializer.serializeWithoutKey(fragment.baseUpdate, tables, out, version.messageVersion()); TxnReferenceOperations.serializer.serialize(fragment.referenceOps, tables, out, version); + out.writeBoolean(fragment.timestamp != NO_TIMESTAMP); Review Comment: can you say more what you are thinking? Timestamps are large so not sure if there would be any space savings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org