sklaha commented on code in PR #249:
URL: https://github.com/apache/cassandra-sidecar/pull/249#discussion_r2286637249


##########
adapters/adapters-base/src/main/java/org/apache/cassandra/sidecar/adapters/base/jmx/StorageJmxOperations.java:
##########
@@ -198,4 +198,37 @@ public interface StorageJmxOperations
      * Triggers start gossip
      */
     void startGossiping();
+
+    /**
+     * Returns the number of concurrent compactors configured for the node
+     * @return number of concurrent compactors
+     */
+    int getConcurrentCompactors();
+
+    /**
+     * Returns the compaction throughput limit in MiB per second as a double
+     * @return compaction throughput limit
+     */
+    double getCompactionThroughputMbPerSec();

Review Comment:
   I removed it.



##########
adapters/adapters-base/src/main/java/org/apache/cassandra/sidecar/adapters/base/jmx/StorageJmxOperations.java:
##########
@@ -198,4 +198,37 @@ public interface StorageJmxOperations
      * Triggers start gossip
      */
     void startGossiping();
+
+    /**
+     * Returns the number of concurrent compactors configured for the node
+     * @return number of concurrent compactors
+     */
+    int getConcurrentCompactors();
+
+    /**
+     * Returns the compaction throughput limit in MiB per second as a double
+     * @return compaction throughput limit
+     */
+    double getCompactionThroughputMbPerSec();
+
+    /**
+     * Returns the compaction throughput limit in MiB per second as a double 
(alternative method name)
+     * @return compaction throughput limit
+     */
+    double getCompactionThroughtputMibPerSecAsDouble();

Review Comment:
   I removed it.



##########
adapters/adapters-base/src/main/java/org/apache/cassandra/sidecar/adapters/base/jmx/StorageJmxOperations.java:
##########
@@ -198,4 +198,37 @@ public interface StorageJmxOperations
      * Triggers start gossip
      */
     void startGossiping();
+
+    /**
+     * Returns the number of concurrent compactors configured for the node
+     * @return number of concurrent compactors
+     */
+    int getConcurrentCompactors();
+
+    /**
+     * Returns the compaction throughput limit in MiB per second as a double
+     * @return compaction throughput limit
+     */
+    double getCompactionThroughputMbPerSec();
+
+    /**
+     * Returns the compaction throughput limit in MiB per second as a double 
(alternative method name)
+     * @return compaction throughput limit
+     */
+    double getCompactionThroughtputMibPerSecAsDouble();
+
+    /**
+     * Returns current compaction throughput measurements in MiB per second 
for different time windows
+     * @return map of time windows to throughput measurements
+     */
+    Map<String, String> getCurrentCompactionThroughputMebibytesPerSec();

Review Comment:
   I removed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to