smiklosovic commented on code in PR #4323: URL: https://github.com/apache/cassandra/pull/4323#discussion_r2288887336
########## test/unit/org/apache/cassandra/tools/nodetool/HistoryTest.java: ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.tools.nodetool; + +import java.util.List; + +import org.junit.BeforeClass; +import org.junit.Test; + +import org.apache.cassandra.io.util.File; +import org.apache.cassandra.io.util.FileUtils; +import org.apache.cassandra.tools.Output; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +public class HistoryTest Review Comment: @Mmuzaf No, I do not think so. You want me to execute "nodetool sjk" and then look into ~/.cassandra/nodetool.history file? I do not think this is a good idea because as I said, the path to history file is wired right now. So as you test, a lot of tests can execute nodetool commands. So all these commands would be visible in that history file, right? I do not think this is isolated enough. Test suite is basically changing the content of this file as tests are progressing. So it is changing "under the hands". For that reason I want to have a way how to completely isolate the history file and have its content under control to make further assertions on that (various edge conditions etc as shown in methods below). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
