dcapwell commented on PR #4197: URL: https://github.com/apache/cassandra/pull/4197#issuecomment-3208245655
i think my thinking is there are a few different cases 1) 1 node is missing accord.enabled but its on for others... in this case we would fail every message to that node... if you enable and restart i don't recall that we will rebootstrap to recover. 2) you no longer want accord so you migrated away and disabled... in this case the patch makes sense to me 3) accord is on tables but you disabled cross the fleet... i think we would fail for every query to these tables as the AccordServices can't coordinate? I think 1/3 can be solved by checking at startup if accord is on a table but disabled locally, then shutdown as its unsafe. For 2 this patch should be enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
