absurdfarce commented on code in PR #2051:
URL: 
https://github.com/apache/cassandra-java-driver/pull/2051#discussion_r2289517208


##########
osgi-tests/src/test/java/com/datastax/oss/driver/internal/osgi/support/BundleOptions.java:
##########
@@ -102,6 +102,16 @@ public static CompositeOption logbackBundles() {
         options(
             mavenBundle("ch.qos.logback", 
"logback-classic").versionAsInProject(),
             mavenBundle("ch.qos.logback", "logback-core").versionAsInProject(),
+
+            // slf4j 2.x requires spifly in order to operate in an OSGi context
+            mavenBundle("org.apache.aries.spifly", 
"org.apache.aries.spifly.dynamic.bundle")
+                .version("1.3.7"),
+            mavenBundle("org.apache.aries", 
"org.apache.aries.util").version("1.1.1"),
+            mavenBundle("org.ow2.asm", "asm").version("9.6"),
+            mavenBundle("org.ow2.asm", "asm-commons").version("9.6"),
+            mavenBundle("org.ow2.asm", "asm-util").version("9.6"),
+            mavenBundle("org.ow2.asm", "asm-tree").version("9.6"),
+            mavenBundle("org.ow2.asm", "asm-analysis").version("9.6"),

Review Comment:
   This code was discovered and implemented independently by @lukasz-antoniak . 
 Huge hat tip to him for his contribution here!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to