dcapwell commented on code in PR #4328:
URL: https://github.com/apache/cassandra/pull/4328#discussion_r2292165239
##########
src/java/org/apache/cassandra/cql3/statements/CQL3CasRequest.java:
##########
@@ -558,15 +558,13 @@ private List<TxnWrite.Fragment>
createWriteFragments(ClientState state)
// see CASSANDRA-18337
ModificationStatement modification = update.stmt.forTxn();
QueryOptions options = update.options;
- TxnWrite.Fragment fragment =
modification.getTxnWriteFragment(idx++, state, options, partitionKey);
- fragments.add(fragment);
+ fragments.addAll(modification.getTxnWriteFragment(idx++, state,
options, partitionKey));
Review Comment:
tested what happens when you have range tombstones (which allows this
function to return empty list) and CAS blocks it before we get here
```
org.apache.cassandra.exceptions.InvalidRequestException: DELETE statements
must restrict all PRIMARY KEY columns with equality relations in order to
delete non static columns
at
org.apache.cassandra.cql3.statements.RequestValidations.invalidRequest(RequestValidations.java:358)
at
org.apache.cassandra.cql3.statements.RequestValidations.checkTrue(RequestValidations.java:61)
at
org.apache.cassandra.cql3.statements.RequestValidations.checkFalse(RequestValidations.java:255)
at
org.apache.cassandra.cql3.statements.DeleteStatement$Parsed.prepareInternal(DeleteStatement.java:197)
at
org.apache.cassandra.cql3.statements.ModificationStatement$Parsed.prepare(ModificationStatement.java:1179)
at
org.apache.cassandra.cql3.statements.ModificationStatement$Parsed.prepare(ModificationStatement.java:1166)
at
org.apache.cassandra.cql3.statements.ModificationStatement$Parsed.prepare(ModificationStatement.java:1138)
at
org.apache.cassandra.cql3.QueryProcessor.getStatement(QueryProcessor.java:959)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
