dcapwell commented on code in PR #4317:
URL: https://github.com/apache/cassandra/pull/4317#discussion_r2294203599
##########
src/java/org/apache/cassandra/schema/ColumnMetadata.java:
##########
@@ -737,7 +738,7 @@ public void serialize(ColumnMetadata t, DataOutputPlus out,
Version version) thr
ColumnConstraints.serializer.serialize(t.columnConstraints, out, version);
}
if (version.isAtLeast(Version.V7))
- out.writeInt(t.uniqueId);
+ out.writeVInt32(t.uniqueId);
Review Comment:
the value is defined as ```int nextId = Math.max(0, maxAssignedUniqueId +
1);```
so should we use unsigned vint?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
