yifan-c commented on code in PR #249: URL: https://github.com/apache/cassandra-sidecar/pull/249#discussion_r2302722580
########## server-common/src/main/java/org/apache/cassandra/sidecar/common/server/data/CompactionStatsData.java: ########## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.common.server.data; + +import java.util.List; +import java.util.Map; + +import org.apache.cassandra.sidecar.common.DataObjectBuilder; + +/** + * Data object representing compaction statistics + */ +public class CompactionStatsData +{ + private final long concurrentCompactors; + private final Map<String, Map<String, Integer>> pendingTasks; + private final long totalPendingTasks; + private final long completedCompactions; + private final long dataCompacted; + private final long abortedCompactions; + private final long reducedCompactions; Review Comment: Just picking this file for an example. Those members can be changed to `public final` and remove the getters. For the response object, the getters are kept merely because of the `@JsonProperty` annotation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
