worryg0d commented on code in PR #1903:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1903#discussion_r2336282963
##########
conn.go:
##########
@@ -1990,9 +1981,13 @@ func (c *Conn) awaitSchemaAgreement(ctx context.Context)
(err error) {
}
var (
- ErrQueryArgLength = errors.New("gocql: query argument length
mismatch")
ErrTimeoutNoResponse = errors.New("gocql: no response received from
cassandra within timeout period")
- ErrTooManyTimeouts = errors.New("gocql: too many query timeouts on
the connection")
ErrConnectionClosed = errors.New("gocql: connection closed waiting for
response")
ErrNoStreams = errors.New("gocql: no streams available on
connection")
+
+ // Deprecated: TimeoutLimit was removed so this is never returned by
the driver now
+ ErrTooManyTimeouts = errors.New("gocql: too many query timeouts on the
connection")
+
+ // Deprecated: Never returned by the driver
+ ErrQueryArgLength = errors.New("gocql: query argument length mismatch")
Review Comment:
Good decision to leave this so not to break existing code bases if they rely
on these errors :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
