worryg0d commented on PR #1908: URL: https://github.com/apache/cassandra-gocql-driver/pull/1908#issuecomment-3297619857
Hi @rhymf14. I had a quick look to understand the changes better, and here’s a short breakdown: 1. I see that it replaces gocql’s built-in LRU cache with the external caching library [maypok86/otter](maypok86/otterhttps://github.com/maypok86/otter). The motivation behind this change isn’t entirely clear—could you share the main goal? Adding some benchmarks to compare both implementations would also be good. 2. There’s no GitHub issue or Jira ticket linked. Having one would be great for tracking purposes. 3. This patch bumps the required Go version to 1.24.6, which is a big jump from the current 1.19 used on the trunk branch. 4. It looks like the patch doesn’t include recent changes from trunk, such as CASSGO-1 and CASSGO-22. Since they overlap with this implementation, it may be worth reconciling them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
