belliottsmith commented on code in PR #254:
URL: https://github.com/apache/cassandra-accord/pull/254#discussion_r2355942107
##########
accord-core/src/main/java/accord/local/Bootstrap.java:
##########
@@ -273,7 +273,7 @@ public void fail(Ranges ranges, Throwable failure)
store.agent().onFailedBootstrap(attempt, "PartialFetch",
newFailures, () -> {
node.scheduler().selfRecurring(() -> {
- store.execute((PreLoadContext.Empty) () -> "Restart
Bootstrap", safeStore -> restart(safeStore, newFailures.slice(allValid,
Minimal), attempt + 1), store.agent());
+ store.execute((PreLoadContext.Empty) () -> "Restart
Bootstrap", safeStore -> { restart(safeStore, newFailures.slice(allValid,
Minimal), attempt + 1); }, store.agent());
Review Comment:
Hmm, ok. So we don't use this specific override but we do use the other
Function overrides. So, I don't have a strong opinion but I do like balancing
the various APIs for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
