ifesdjeen commented on code in PR #4383:
URL: https://github.com/apache/cassandra/pull/4383#discussion_r2355871986


##########
test/unit/org/apache/cassandra/db/virtual/AccordDebugKeyspaceTest.java:
##########
@@ -120,15 +127,21 @@ public class AccordDebugKeyspaceTest extends CQLTester
     @BeforeClass
     public static void setUpClass()
     {
+        Config.setOverrideLoadConfig(() -> {
+            Config config = new YamlConfigurationLoader().loadConfig();
+            config.accord.queue_shard_count = new OptionaldPositiveInt(1);

Review Comment:
   is "Optionald" here a typo? Doesn't look like your typo but still



##########
.gitmodules:
##########
@@ -1,4 +1,4 @@
 [submodule "modules/accord"]
        path = modules/accord
-       url = https://github.com/apache/cassandra-accord.git
-       branch = trunk
+       url = https://github.com/belliottsmith/cassandra-accord.git

Review Comment:
   Just a reminder to switch to Accord before merging. I'm sure you had it 
planned though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to