dcapwell commented on code in PR #249:
URL: https://github.com/apache/cassandra-accord/pull/249#discussion_r2331365174


##########
accord-core/src/main/java/accord/utils/LargeBitSet.java:
##########
@@ -320,7 +320,7 @@ public final int nextSetBitBefore(int i, int exclBound, int 
ifNotFound)
     private int nextSetBitInternal(int i, int exclIndexBound, int ifNotFound)
     {
         Invariants.requireArgument(i >= 0);
-        Invariants.requireArgument(i <= size());

Review Comment:
   the interface doesn't expose a way to know the size, so you need to rely on 
`nextSetBitInternal` to know when to complete iterating, so rather than failing 
return `-1`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to