belliottsmith commented on PR #4373: URL: https://github.com/apache/cassandra/pull/4373#issuecomment-3280853695
> Maybe a test or two? Looks like you're testing the accord table but not verifying the lazy vtable interface at all. I do not see additional value in dedicated testing, when it is exercised by the accord virtual table tests. Those tables are arguably much more in need of expanded test coverage. Either way, while it's not an unreasonable request, I also don't have time. So if you want this, I will have to leave the patch unmerged for the foreseeable future, and use it only internally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
