smiklosovic commented on code in PR #4394: URL: https://github.com/apache/cassandra/pull/4394#discussion_r2377851191
########## src/java/org/apache/cassandra/tools/nodetool/Ping.java: ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.tools.nodetool; + +import java.util.Map; +import java.util.Map.Entry; + +import org.apache.cassandra.tools.NodeProbe; +import org.apache.cassandra.tools.nodetool.formatter.TableBuilder; +import picocli.CommandLine.Command; +import picocli.CommandLine.Option; +import picocli.CommandLine.Parameters; + +@Command(name = "ping", description = "Sends message to all live nodes in gossip") +public class Ping extends AbstractCommand +{ + @Option(names = {"-v", "--verbose"}, description = "Enable verbose output") + private boolean verbose = false; + + @Option(names = {"-j", "--json"}, description = "Output results in JSON format") + private boolean json = false; + + @Override + public void execute(NodeProbe probe) + { + try + { + if (!json) Review Comment: we are also happening to support YAML format. See e.g. `CompactionHistory` nodetool command. Use same classes / infrastructure code as there like: StatsHolder data = new CompactionHistoryHolder(probe, humanReadable); StatsPrinter printer = CompactionHistoryPrinter.from(outputFormat); printer.print(data, probe.output().out); Create similar classes and reuse what is possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
