maedhroz commented on code in PR #4393:
URL: https://github.com/apache/cassandra/pull/4393#discussion_r2380345317
##########
src/java/org/apache/cassandra/config/GuardrailsOptions.java:
##########
@@ -181,6 +185,45 @@ public void setColumnsPerTableThreshold(int warn, int fail)
x -> config.columns_per_table_fail_threshold
= x);
}
+ @Override
+ public Set<String> getKeyspacePropertiesWarned()
+ {
+ return config.keyspace_properties_warned;
+ }
+
+ public void setKeyspacePropertiesWarned(Set<String> properties)
+ {
+ updatePropertyWithLogging("keyspace_properties_warned",
+ validateKeyspaceProperties(properties,
"keyspace_properties_warned"),
+ () -> config.keyspace_properties_warned, x ->
config.keyspace_properties_warned = x);
Review Comment:
nit: Here and in the methods below, let's alighn the arguments horizontally.
For example...
```suggestion
() -> config.keyspace_properties_warned, x
-> config.keyspace_properties_warned = x);
```
##########
src/java/org/apache/cassandra/config/GuardrailsOptions.java:
##########
@@ -181,6 +185,45 @@ public void setColumnsPerTableThreshold(int warn, int fail)
x -> config.columns_per_table_fail_threshold
= x);
}
+ @Override
+ public Set<String> getKeyspacePropertiesWarned()
+ {
+ return config.keyspace_properties_warned;
+ }
+
+ public void setKeyspacePropertiesWarned(Set<String> properties)
+ {
+ updatePropertyWithLogging("keyspace_properties_warned",
+ validateKeyspaceProperties(properties,
"keyspace_properties_warned"),
+ () -> config.keyspace_properties_warned, x ->
config.keyspace_properties_warned = x);
Review Comment:
nit: Here and in the methods below, let's align the arguments horizontally.
For example...
```suggestion
() -> config.keyspace_properties_warned, x
-> config.keyspace_properties_warned = x);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
