frankgh commented on code in PR #262:
URL: https://github.com/apache/cassandra-sidecar/pull/262#discussion_r2382020621
##########
server/src/main/java/org/apache/cassandra/sidecar/acl/AuthCache.java:
##########
@@ -61,14 +63,16 @@ protected AuthCache(String name,
ExecutorPools executorPools,
Function<K, V> loadFunction,
Supplier<Map<K, V>> bulkLoadFunction,
- CacheConfiguration cacheConfiguration)
+ CacheConfiguration cacheConfiguration,
+ CacheStatsCounter cacheMetrics)
{
this.name = name;
this.vertx = vertx;
this.internalPool = executorPools.internal();
this.loadFunction = loadFunction;
this.bulkLoadFunction = bulkLoadFunction;
this.config = cacheConfiguration;
+ this.cacheMetrics = cacheMetrics;
Review Comment:
we should validate this is not null
```suggestion
this.cacheMetrics = Objects.requireNonNull(cacheMetrics,
"cacheMetrics is required");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
