iamaleksey commented on code in PR #4392:
URL: https://github.com/apache/cassandra/pull/4392#discussion_r2382367152
##########
src/java/org/apache/cassandra/replication/MutationJournal.java:
##########
@@ -73,7 +122,40 @@ public void shutdownBlocking()
public RecordPointer write(ShortMutationId id, Mutation mutation)
{
- return journal.blockingWrite(id, mutation);
+ // TODO (required): why are we using blocking write here? We
can/should wait for completion on `close` of WriteContext.
Review Comment:
I think we do the same with vanilla commit log. Here we need to mutation to
be fully durable before we update/share witnessed state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
