maedhroz commented on code in PR #4380:
URL: https://github.com/apache/cassandra/pull/4380#discussion_r2411213686
##########
test/unit/org/apache/cassandra/index/sai/functional/CompactionTest.java:
##########
@@ -352,4 +358,54 @@ public void testConcurrentIndexDropWithCompaction() throws
Throwable
.isInstanceOf(InvalidQueryException.class)
.hasMessage(StatementRestrictions.REQUIRES_ALLOW_FILTERING_MESSAGE);
}
+
+ @Test
+ public void testSegmentBuilderFlushWithShardedCompaction() throws Throwable
+ {
+ int shards = 64;
+ String createTable = "CREATE TABLE %s (id1 TEXT PRIMARY KEY, v1 INT,
v2 TEXT) WITH compaction = " +
+ "{'class' : 'UnifiedCompactionStrategy',
'enabled' : false, 'base_shard_count': " + shards + ", 'min_sstable_size':
'1KiB' }";
+ createTable(createTable);
+ createIndex(String.format(CREATE_INDEX_TEMPLATE, "v1"));
+ createIndex(String.format(CREATE_INDEX_TEMPLATE, "v2"));
+ disableCompaction(keyspace(), currentTable());
+
+ int rowsPerSSTable = 2000;
+ int numSSTables = 4;
+ int key = 0;
+ for (int s = 0; s < numSSTables; s++)
+ {
+ for (int i = 0; i < rowsPerSSTable; i++)
+ {
+ execute("INSERT INTO %s (id1, v1, v2) VALUES (?, 0,
'01e2wefnewirui32e21e21wre')", Integer.toString(key++));
+ }
+ flush();
+ }
+
+ ExecutorService executor = Executors.newSingleThreadExecutor();
+ try
+ {
+ Future<?> future = executor.submit(() -> {
+ getCurrentColumnFamilyStore().forceMajorCompaction(false, 1);
+ waitForCompactions();
+ });
+
+ // verify that it's not accumulating segment builders
+ while (!future.isDone())
+ {
+ // ACTIVE_BUILDER_COUNT starts from 0. There are 2 segments
for 2 indexes
+
assertThat(SegmentBuilder.getActiveBuilderCount()).isGreaterThanOrEqualTo(0).isLessThanOrEqualTo(2);
+ }
+ future.get(30, TimeUnit.SECONDS);
+
+ // verify results are sharded
+
assertThat(getCurrentColumnFamilyStore().getLiveSSTables()).hasSize(shards);
+ }
+ finally
+ {
+ executor.shutdown();
+ executor.awaitTermination(30, TimeUnit.SECONDS);
+ assertThat(executor.isTerminated()).isTrue();
Review Comment:
nit: I guess what I meant was that you can just look at the return value
from `awaitTermination()`. (Has the side effect of making the static analyzers
happy...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
