smiklosovic commented on code in PR #4411:
URL: https://github.com/apache/cassandra/pull/4411#discussion_r2436511152
##########
src/java/org/apache/cassandra/schema/KeyspaceParams.java:
##########
@@ -163,6 +186,8 @@ public void serialize(KeyspaceParams t, DataOutputPlus out,
Version version) thr
{
ReplicationParams.serializer.serialize(t.replication, out,
version);
out.writeBoolean(t.durableWrites);
+ out.writeUTF(t.comment);
Review Comment:
so for column metadata you said that we need new version (Version.V8) but
for this we do not need it? I think that is not how it works because older
version would not be able to de/serialize it. I think you should follow how it
is done in ColumnMetadata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
