frankgh commented on code in PR #268:
URL: https://github.com/apache/cassandra-sidecar/pull/268#discussion_r2399626238
##########
server/src/main/java/org/apache/cassandra/sidecar/config/yaml/CacheConfigurationImpl.java:
##########
@@ -24,20 +24,24 @@
import org.slf4j.LoggerFactory;
import com.fasterxml.jackson.annotation.JsonProperty;
+import org.apache.cassandra.sidecar.common.DataObjectBuilder;
import
org.apache.cassandra.sidecar.common.server.utils.MillisecondBoundConfiguration;
import org.apache.cassandra.sidecar.config.CacheConfiguration;
-import org.jetbrains.annotations.VisibleForTesting;
/**
* Configuration class that encapsulates parameters needed for Caches
*/
public class CacheConfigurationImpl implements CacheConfiguration
{
private static final Logger LOGGER =
LoggerFactory.getLogger(CacheConfigurationImpl.class);
+ private static final long DEFAULT_MAXIMUM_SIZE = 100;
+ private static final boolean DEFAULT_ENABLED = true;
+ private static final int DEFAULT_WARMUP_RETRIES = 5;
+ private static final MillisecondBoundConfiguration
DEFAULT_WARMUP_RETRY_INTERVAL = MillisecondBoundConfiguration.parse("1s");
protected MillisecondBoundConfiguration expireAfterAccess;
Review Comment:
The setters are used when we have the legacy names in the yaml , for example
`expire_after_access_millis` is the legacy property. New properties should not
have a setter because they should not have a legacy yaml property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
