blambov commented on code in PR #4402:
URL: https://github.com/apache/cassandra/pull/4402#discussion_r2415794836
##########
src/java/org/apache/cassandra/db/compaction/CompactionTask.java:
##########
@@ -71,6 +73,8 @@
public class CompactionTask extends AbstractCompactionTask
{
protected static final Logger logger =
LoggerFactory.getLogger(CompactionTask.class);
+ public static final int MEGABYTE = 1024 * 1024 * 1024;
Review Comment:
This is not right and should either be renamed or corrected.
##########
src/java/org/apache/cassandra/db/compaction/CompactionTask.java:
##########
@@ -71,6 +73,8 @@
public class CompactionTask extends AbstractCompactionTask
{
protected static final Logger logger =
LoggerFactory.getLogger(CompactionTask.class);
+ public static final int MEGABYTE = 1024 * 1024 * 1024;
+ public static final boolean CURSOR_COMPACTION_ENABLED =
SystemProperties.getBoolean("cassandra.enable_cursor_compaction", () -> true);
Review Comment:
Also related to testing, we need to be running _all_ tests both with this
feature enabled as well as disabled.
Let's make sure that among `test`, `test-oa` and `test-latest` we have at
least one that is running with cursor compaction and one without.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
