smiklosovic commented on code in PR #260: URL: https://github.com/apache/cassandra-sidecar/pull/260#discussion_r2372261466
########## server/src/main/java/org/apache/cassandra/sidecar/handlers/role/RoleGenerationHandler.java: ########## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.handlers.role; + +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; +import java.util.Set; +import java.util.function.Predicate; + +import org.apache.commons.lang3.StringUtils; + +import com.google.inject.Inject; +import com.google.inject.Singleton; +import io.vertx.core.http.HttpServerRequest; +import io.vertx.core.json.JsonObject; +import io.vertx.core.net.SocketAddress; +import io.vertx.ext.auth.authorization.Authorization; +import io.vertx.ext.web.RoutingContext; +import org.apache.cassandra.sidecar.acl.authorization.BasicPermissions; +import org.apache.cassandra.sidecar.adapters.base.exception.OperationUnavailableException; +import org.apache.cassandra.sidecar.cluster.CassandraAdapterDelegate; +import org.apache.cassandra.sidecar.common.request.GenerateRoleRequest; +import org.apache.cassandra.sidecar.common.request.data.GenerateRoleRequestPayload; +import org.apache.cassandra.sidecar.concurrent.ExecutorPools; +import org.apache.cassandra.sidecar.handlers.AbstractHandler; +import org.apache.cassandra.sidecar.handlers.AccessProtected; +import org.apache.cassandra.sidecar.utils.CassandraInputValidator; +import org.apache.cassandra.sidecar.utils.InstanceMetadataFetcher; +import org.jetbrains.annotations.NotNull; + +import static java.util.stream.Collectors.toMap; +import static org.apache.cassandra.sidecar.common.request.data.GenerateRoleRequestPayload.PASSWORD_GENERATION_KEY_NAME; +import static org.apache.cassandra.sidecar.common.request.data.GenerateRoleRequestPayload.ROLE_NAME_OPTIONS_KEY_NAME; + +@Singleton +public class RoleGenerationHandler extends AbstractHandler<GenerateRoleRequest> implements AccessProtected +{ + private static final ParameterPredicate PAYLOAD_PARAMETER_ACCEPTANCE_PREDICATE = new ParameterPredicate(); + + /** + * Constructs a handler with the provided {@code metadataFetcher} + * + * @param metadataFetcher the interface to retrieve instance metadata + * @param executorPools the executor pools for blocking executions + * @param validator a validator instance to validate Cassandra-specific input + */ + @Inject + public RoleGenerationHandler(InstanceMetadataFetcher metadataFetcher, ExecutorPools executorPools, CassandraInputValidator validator) + { + super(metadataFetcher, executorPools, validator); + } + + @Override + protected void handleInternal(RoutingContext context, + HttpServerRequest httpRequest, + @NotNull String host, + SocketAddress remoteAddress, + GenerateRoleRequest request) + { + executorPools.service() + .executeBlocking(() -> + { + CassandraAdapterDelegate delegate = metadataFetcher.delegate(host); + + if (delegate.version().major < 5 && !request.requestBody().sidecarGeneration) Review Comment: for now just this to be able to test it somehow, will be bumped when Cassandra 6 is out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
