belliottsmith commented on PR #4324: URL: https://github.com/apache/cassandra/pull/4324#issuecomment-3327545794
Maybe for now we just make the small change to ensure correctness on recycling using either the offset technique, or introducing a delay to recycling (e.g. schedule a task to make the id visible in 1s)? Or else simply disable recycling until we fix it? But, I am not opposed to merging as is - I think the chance of any actual bug appearing there is very low, and we aren't planning an imminent release anyway. But e.g. the delay technique is ~30s of work and basically guarantees correctness in all practical senses. I'll leave it to you to decide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
