smiklosovic commented on code in PR #4411:
URL: https://github.com/apache/cassandra/pull/4411#discussion_r2436412264
##########
src/java/org/apache/cassandra/db/marshal/UserType.java:
##########
@@ -66,19 +66,45 @@ public class UserType extends TupleType implements
SchemaElement
public final String keyspace;
public final ByteBuffer name;
+ public final String comment;
+ public final String securityLabel;
private final List<FieldIdentifier> fieldNames;
private final List<String> stringFieldNames;
+ private final Map<FieldIdentifier, String> fieldComments;
+ private final Map<FieldIdentifier, String> fieldSecurityLabels;
private final boolean isMultiCell;
private final UserTypeSerializer serializer;
public UserType(String keyspace, ByteBuffer name, List<FieldIdentifier>
fieldNames, List<AbstractType<?>> fieldTypes, boolean isMultiCell)
+ {
+ this(keyspace, name, fieldNames, fieldTypes, isMultiCell, "", "",
Collections.emptyMap(), Collections.emptyMap());
Review Comment:
can you please create something like `private static final String
EMPTY_STRING = ""` and reuse it everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
