smiklosovic commented on code in PR #4399: URL: https://github.com/apache/cassandra/pull/4399#discussion_r2410757796
########## src/java/org/apache/cassandra/db/compression/ManualTrainingOptions.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.db.compression; + +import java.util.Map; + +/** + * Configuration options for manual compression dictionary training. + * This class encapsulates the parsed and validated parameters needed for training. + */ +public class ManualTrainingOptions +{ + private final int maxSamplingDurationSeconds; + + public ManualTrainingOptions(int maxSamplingDurationSeconds) + { + if (maxSamplingDurationSeconds <= 0) + { + throw new IllegalArgumentException("maxSamplingDurationSeconds must be positive, got: " + maxSamplingDurationSeconds); + } + this.maxSamplingDurationSeconds = maxSamplingDurationSeconds; + } + + /** + * Parse options from a string map, typically from JMX/MBean calls. + * + * @param options the string map containing training options + * @return parsed and validated ManualTrainingOptions + * @throws IllegalArgumentException if required parameters are missing or invalid + */ + public static ManualTrainingOptions fromStringMap(Map<String, String> options) + { + if (options == null || !options.containsKey("maxSamplingDurationSeconds")) Review Comment: are we really going to use camel case? not snake case? not sure what is better or what we use consistently. Also we might probably extract this string to a standalone constant in this class. Easy to mess it up by typing it constantly. ########## src/java/org/apache/cassandra/db/compression/CompressionDictionaryManagerMBean.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.db.compression; + +import java.util.Map; + +public interface CompressionDictionaryManagerMBean +{ + /** + * Starts sampling and training for this table. + * + * @param options options for the training process (currently unused, reserved for future extensions) + * @throws IllegalArgumentException if table doesn't support dictionary compression Review Comment: Throw `UnsupportedOperationException` then? ########## src/java/org/apache/cassandra/db/compression/ICompressionDictionaryCache.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.db.compression; + +import javax.annotation.Nullable; + +/** + * Interface for managing compression dictionary caching and current dictionary state. + * <p> + * Implementations handle: + * - Local caching of compression dictionaries with automatic cleanup + * - Managing the current active dictionary for write operations + * - Thread-safe access to cached dictionaries + */ +public interface ICompressionDictionaryCache extends AutoCloseable +{ + /** + * Gets the current active compression dictionary. + * + * @return the current compression dictionary, or null if no dictionary is available + */ + @Nullable + CompressionDictionary getCurrent(); Review Comment: It would be better style to work with `Optional<CompressionDictionary>` than to work with `Nullable` annotations. Feels just more Java idiomatic than this. Applicable for `get` method too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
