sarankk commented on code in PR #258:
URL: https://github.com/apache/cassandra-sidecar/pull/258#discussion_r2449604534
##########
server/src/main/java/org/apache/cassandra/sidecar/handlers/NodeDecommissionHandler.java:
##########
@@ -84,7 +85,11 @@ public void handleInternal(RoutingContext context,
{
StorageOperations operations =
metadataFetcher.delegate(host).storageOperations();
NodeDecommissionJob job = new NodeDecommissionJob(UUIDs.timeBased(),
operations, isForce);
- handleOperationalJob(this.jobManager, this.config, context, job);
+ this.jobManager.trySubmitJob(job,
+ (completedJob, exception) ->
+
OperationalJobUtils.sendStatusBasedResponse(context, completedJob, exception),
+ executorPools.service(),
Review Comment:
Nit: We already inject `ExecutorPools` in `OperationalJobManager`. We can
use service pool from there instead of passing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
