smiklosovic commented on code in PR #4411:
URL: https://github.com/apache/cassandra/pull/4411#discussion_r2454775502
##########
src/java/org/apache/cassandra/schema/ColumnMetadata.java:
##########
@@ -739,6 +770,15 @@ public void serialize(ColumnMetadata t, DataOutputPlus
out, Version version) thr
}
if (version.isAtLeast(Version.V7))
out.writeVInt32(t.uniqueId);
+ if (version.isAtLeast(Version.V8))
+ {
+ out.writeBoolean(t.comment != null);
Review Comment:
if (t.comment != null)
{
out.writeBoolean(true);
out.writeUTF(t.comment);
}
else
{
out.writeBoolean(false);
}
Why can not you be more succinct? You are making just one null check here
instead of twice. Same style should be applied everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
