smiklosovic commented on code in PR #4439:
URL: https://github.com/apache/cassandra/pull/4439#discussion_r2465481433
##########
test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java:
##########
@@ -68,15 +68,16 @@ public void
testNonFrozenCollectionsAreIncompatibleWithBlob() throws Throwable
}
@Test
- public void testFrozenCollectionsAreCompatibleWithBlob()
+ public void testFrozenCollectionsAreNotCompatibleWithBlob()
{
String[] collectionTypes = new String[] {"frozen<map<int, int>>",
"frozen<set<int>>", "frozen<list<int>>"};
for (String type : collectionTypes)
{
createTable("CREATE TABLE %s (a int, b " + type + ", PRIMARY KEY
(a));");
alterTable("ALTER TABLE %s DROP b;");
- alterTable("ALTER TABLE %s ADD b blob;");
+ assertInvalidMessage("Cannot re-add previously dropped column 'b'
of type blob, incompatible with previous type " + type,
Review Comment:
@Dekrate
this reads like dropped column 'b' was of type blob while it was actually
frozen. It would be more natural to say
`Cannot add a column 'b' of type blob, incompatible with previously dropped
column 'b' of type frozen ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
