netudima commented on code in PR #4454:
URL: https://github.com/apache/cassandra/pull/4454#discussion_r2479609795
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -1220,6 +1220,12 @@ else if (conf.max_value_size.toMebibytes() >= 2048)
// run audit logging options through sanitation and validation
if (conf.audit_logging_options != null)
setAuditLoggingOptions(conf.audit_logging_options);
+
+ // just run through the validation by setting current values back to
their setters, so we are sure that their values are valid
+ DatabaseDescriptor.setGCLogThreshold((int)
DatabaseDescriptor.getGCLogThreshold());
Review Comment:
it looks like all other setters in DatabaseDescriptor throw
IllegalArgumentException, maybe for consistency it makes sense to do it for
these setters as well and do an reserve conversion of exceptions here instead
of MBean setters..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
