smiklosovic commented on code in PR #4458:
URL: https://github.com/apache/cassandra/pull/4458#discussion_r2481393575
##########
src/java/org/apache/cassandra/db/compression/CompressionDictionary.java:
##########
@@ -188,9 +220,10 @@ enum Kind
// Order matters: the enum ordinal is serialized
ZSTD
{
- public CompressionDictionary createDictionary(DictId dictId,
byte[] dict)
+ @Override
+ public CompressionDictionary createDictionary(DictId dictId,
byte[] dict, int checksum)
{
- return new ZstdCompressionDictionary(dictId, dict);
+ return new ZstdCompressionDictionary(dictId, dict, checksum);
Review Comment:
This seems way more comfortable to do. If a reviewer looks into where
checksum is worked with, we have it every time, no reason to not use that so we
do not need to compute it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
